[PATCH] D42188: [LLD][PDB] Implement FIXME: Warn on missing TypeServer PDB rather than error

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 17 13:15:02 PST 2018


rnk added a comment.

In https://reviews.llvm.org/D42188#979174, @colden wrote:

> Ok, that makes sense.
>
> I'm 99% done implementing the change, but what I'm seeing is when a lib is missing it's PDB, every single obj inside of it tosses the warning. Is this the behavior we want? Or is there another way to make sure the warning only goes once per file?
>
> With the warning inside PDBLinker::maybeMergeTypeServerPDB, it just warns the first time the file load is attempted.


I think MSVC will also warn once for every object. I think it's pretty reasonable, this isn't something you want to ignore for long.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42188





More information about the llvm-commits mailing list