[PATCH] D42030: [WebAssembly] Define __heap_base global

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 17 11:59:40 PST 2018


sbc100 added a comment.

The actual low level memory allocator (__builtin_wasm_grow_memory, or the JS version as I've used here: https://github.com/jfbastien/musl/blob/wasm-prototype-1/arch/wasm32/wasm.js#L1358)  can only allocate at a 64k granularity.   Setting the page size to something smaller to reduce the memory overhead of a given mmap implementation doesn't make a lot of sense me.    @dschuff, what do you think?

Also, I don't really understand your logic regarding the size of your bitmap.  Surely the larger the pages, the fewer pages exist, the smaller the bitmap required to track them?   Perhaps I'm missing something?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42030





More information about the llvm-commits mailing list