[PATCH] D42193: [WebAssembly] Remove DEBUG_FUNCTION_NAME after llvm change

Phabricator via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 17 11:37:54 PST 2018


This revision was not accepted when it landed; it landed in state "Needs Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLD322745: [WebAssembly] Remove DEBUG_FUNCTION_NAME after llvm change (authored by sbc, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D42193?vs=130235&id=130239#toc

Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42193

Files:
  test/wasm/archive.ll
  wasm/InputFiles.cpp


Index: test/wasm/archive.ll
===================================================================
--- test/wasm/archive.ll
+++ test/wasm/archive.ll
@@ -27,10 +27,7 @@
 ; correctly.
 
 ; CHECK:      00000003 T _start
-; CHECK-NEXT: 00000003 T _start
 ; CHECK-NEXT: 00000001 T bar
-; CHECK-NEXT: 00000001 T bar
-; CHECK-NEXT: 00000002 T foo
 ; CHECK-NEXT: 00000002 T foo
 
 ; Verify that symbols from unused objects don't appear in the symbol table
Index: wasm/InputFiles.cpp
===================================================================
--- wasm/InputFiles.cpp
+++ wasm/InputFiles.cpp
@@ -252,9 +252,6 @@
     case WasmSymbol::SymbolType::GLOBAL_IMPORT:
       S = createUndefined(WasmSym, Symbol::Kind::UndefinedGlobalKind);
       break;
-    case WasmSymbol::SymbolType::DEBUG_FUNCTION_NAME:
-      // These are for debugging only, no need to create linker symbols for them
-      continue;
     }
 
     Symbols.push_back(S);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42193.130239.patch
Type: text/x-patch
Size: 933 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180117/08f25d75/attachment.bin>


More information about the llvm-commits mailing list