[PATCH] D32498: [CodeView] omit forward references for unnamed structs and unions

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm with one nit, thanks!



================
Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:1846-1847
+  // structs should not have circular references.
+  if (Ty->getName().empty() && Ty->getIdentifier().empty() &&
+      !Ty->isForwardDecl()) {
+    // If this unnamed complete type is already in the process of being defined
----------------
Can you wrap this condition (which is duplicated below) into a helper, something like `shouldAlwaysEmitCompleteClassType`?


https://reviews.llvm.org/D32498