[PATCH] D41658: [RISCV] Encode RISCV specific ELF e_flags to RISCV Binary by RISCVTargetStreamer

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 17 06:34:59 PST 2018


asb accepted this revision.
asb added a comment.
This revision is now accepted and ready to land.

clang-format shows me a few minor tweaks:

- RISCVELFStreamer.h include should come first in RISCVELFStreamer.cpp
- RISCVMCAsmInfo.h include is now improperly sorted in RISCVMCTargetDesc.cpp
- RISCVTargetStreamer constructor can fit on one line in 80 chars `RISCVTargetStreamer::RISCVTargetStreamer(MCStreamer &S) : MCTargetStreamer(S) {}`

Otherwise it looks good to me. I can't see any hard dependency on a custom RISCVAsmStreamer (though it's likely we'll want to add it later). Ana - are you happy for this patch to be committed as-is?


Repository:
  rL LLVM

https://reviews.llvm.org/D41658





More information about the llvm-commits mailing list