[PATCH] D38315: WIP: [ARM] Add f16 type support and code generation (part 1/2)

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 17 04:06:02 PST 2018


SjoerdMeijer added a comment.

Hi Oliver, 
Thanks for pointing this out and this alternative approach to adjust the calling convention lowering looks more robust. What I mean by that is:

- although that approach does not come for free and involves creating a custom CCState and implementation,
- it avoids custom lowering of the loads/stores, and the few other corner cases that needed changing. As we don't this anymore, we are not risking having missed another corner case.

So I will start exploring the CCState approach.


https://reviews.llvm.org/D38315





More information about the llvm-commits mailing list