[PATCH] D42081: [WebAssembly] Symbol changes #2: Table relocs, LLD

[Nicholas Wilson via Phabricator via llvm-commits]

ncw added inline comments.


================
Comment at: wasm/InputFiles.cpp:70
 uint32_t ObjFile::relocateTableIndex(uint32_t Original) const {
-  Symbol *Sym = TableSymbols[Original];
+  Symbol *Sym = FunctionSymbols[Original];
   uint32_t Index = Sym->hasTableIndex() ? Sym->getTableIndex() : 0;
----------------
sbc100 wrote:
> Can this function now be removed?
I don't think it can be removed. Function indexes are definitely different to table indexes: relocateTableIndex calls getTableIndex which is necessary for performing the actual relocation.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42081