[PATCH] D34135: [LVI] Add initial result to avoid infinite getValueFromCondition recursion

[Mikael Holmén via Phabricator via llvm-commits]

uabelho added a comment.

In https://reviews.llvm.org/D34135#977113, @brzycki wrote:

> Hi @uabelho, in order to actually use the DT you have to perform a flush on DDT like so:
>
>   DominatorTree *DT = DDT->flush();
>   !DT->isReachableFromEntry(BB);
>   ...
>
>
> This flush() call should only happen when you're absolutely sure you need the DT because it's potentially expensive. But the whole point of the deferred nature is to flush when you need it, and in this case you need it.


Great, I'll try this out then.

> I haven't tested flushing() in arbitrary locations in the code. It should just work but it might cause an assert inside DT. If you see one let me know, I'd be interested to understand why.

Ok, I'll let you know if I find something odd.

Thanks!


https://reviews.llvm.org/D34135