[PATCH] D42156: Force lit to execute the ASan and TSan tests on iOS devices sequentially

Kuba (Brecka) Mracek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 16 20:56:33 PST 2018


kubamracek added inline comments.


================
Comment at: test/asan/lit.cfg:223
+    config.parallelism_group = "darwin-ios-device-sanitizer"
+    lit_config.warning("ASan ios device test cases being run sequentially")
+    lit_config.parallelism_groups["darwin-ios-device-sanitizer"] = 1
----------------
Do we need the warning? I would prefer to drop it. If you think it's still useful, please use the spelling "iOS" for the name of the OS.


================
Comment at: test/asan/lit.cfg:224
+    lit_config.warning("ASan ios device test cases being run sequentially")
+    lit_config.parallelism_groups["darwin-ios-device-sanitizer"] = 1
----------------
Can the value "1" and the comment be moved to `test/lit.common.cfg`?


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D42156





More information about the llvm-commits mailing list