[PATCH] D42134: Fix global status page being unable to load due to crash

[Tim Bradgate via Phabricator via llvm-commits]

Tim020 created this revision.
Tim020 created this object with visibility "All Users".
Herald added a subscriber: llvm-commits.

There is a typo in view.py which leads to the server crashing and being unable to display the global status page.

The crash is as follows:

  Exception: Traceback (most recent call last):
    File "/usr/local/lib/python2.7/site-packages/Flask-0.10.1-py2.7.egg/flask/app.py", line 1817, in wsgi_app
      response = self.full_dispatch_request()
    File "/usr/local/lib/python2.7/site-packages/Flask-0.10.1-py2.7.egg/flask/app.py", line 1477, in full_dispatch_request
      rv = self.handle_user_exception(e)
    File "/usr/local/lib/python2.7/site-packages/Flask_RESTful-0.3.6-py2.7.egg/flask_restful/__init__.py", line 273, in error_router
      return original_handler(e)
    File "/usr/local/lib/python2.7/site-packages/Flask-0.10.1-py2.7.egg/flask/app.py", line 1381, in handle_user_exception
      reraise(exc_type, exc_value, tb)
    File "/usr/local/lib/python2.7/site-packages/Flask-0.10.1-py2.7.egg/flask/app.py", line 1475, in full_dispatch_request
      rv = self.dispatch_request()
    File "/usr/local/lib/python2.7/site-packages/Flask-0.10.1-py2.7.egg/flask/app.py", line 1461, in dispatch_request
      return self.view_functions[rule.endpoint](**req.view_args)
    File "/usr/local/lib/python2.7/site-packages/LNT-0.4.1.dev0-py2.7-linux-x86_64.egg/lnt/server/ui/decorators.py", line 67, in wrap
      result = f(**args)
    File "/usr/local/lib/python2.7/site-packages/LNT-0.4.1.dev0-py2.7-linux-x86_64.egg/lnt/server/ui/views.py", line 1334, in v4_global_status
      for baseline, run in machine_run_info)
    File "/usr/local/lib/python2.7/site-packages/LNT-0.4.1.dev0-py2.7-linux-x86_64.egg/lnt/server/ui/views.py", line 1334, in <genexpr>
      for baseline, run in machine_run_info)
  AttributeError: type object 'Sample' has no attribute 'get_hash_of_Binary_field'


Repository:
  rL LLVM

https://reviews.llvm.org/D42134

Files:
  lnt/server/ui/views.py


Index: lnt/server/ui/views.py
===================================================================
--- lnt/server/ui/views.py
+++ lnt/server/ui/views.py
@@ -1352,7 +1352,7 @@
         # Compute comparison results for each machine.
         row.extend((runinfo.get_run_comparison_result(
                         run, baseline, test_id, field,
-                        ts.Sample.get_hash_of_Binary_field),
+                        ts.Sample.get_hash_of_binary_field()),
                     run.id)
                    for baseline, run in machine_run_info)
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42134.130031.patch
Type: text/x-patch
Size: 558 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180116/c315decc/attachment.bin>