[PATCH] D42129: [polly] [ScopInfo] Don't use isl_val_get_num_si.

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added inline comments.


================
Comment at: lib/Analysis/ScopInfo.cpp:3431
 
-        if (isl_val_is_int(Val))
-          ValInt = isl_val_get_num_si(Val);
----------------
There might be a misconception here: `isl_val_is_int` only returns false for fractions. We don't use rational polyhedral sets, so the branch is always taken, even if `Val` exceeds any range.


================
Comment at: lib/Analysis/ScopInfo.cpp:3439
 
         Int.push_back(ValInt);
 
----------------
Does it make sense to fall-through with `ValInt = 1` if the value exceeds the range? It seems to be intended, but I don't see what the effect is.


Repository:
  rPLO Polly

https://reviews.llvm.org/D42129