[PATCH] D41915: [lldCOFF] Print detailed timing information with /VERBOSE

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

LGTM with these changes.

Please update the commit message as it no longer depends on /VERBOSE.



================
Comment at: lld/include/lld/Common/Timer.h:35
+class Timer {
+  std::chrono::time_point<std::chrono::high_resolution_clock> StartTime;
+  std::chrono::nanoseconds Total;
----------------
Move private members after public members.


================
Comment at: lld/include/lld/Common/Timer.h:37
+  std::chrono::nanoseconds Total;
+  llvm::SmallVector<Timer *, 2> Children;
+  std::string Name;
----------------
Please use std::vector.


================
Comment at: lld/include/lld/Common/Timer.h:41
+  void print(int Depth, double TotalDuration, bool Recurse = true) const;
+  explicit Timer(llvm::StringRef Name);
+
----------------
Make this private.


================
Comment at: lld/include/lld/Common/Timer.h:44
+public:
+  friend ScopedTimer;
+
----------------
Please remove `friend`. I believe this file compiles without it.


https://reviews.llvm.org/D41915