[PATCH] D42082: Add DWARF for discriminated unions

Tom Tromey via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 16 11:46:46 PST 2018


tromey added a comment.

In https://reviews.llvm.org/D42082#977368, @probinson wrote:

> DWARF discriminated unions were likely designed to support Pascal variant records, which do allow multiple fields per variant.  If we're going to support discriminated unions (which seems reasonable) then it ought to be general enough to handle the Pascal case.


The reason I did not do this is that I didn't need it for Rust, and it seemed to me that it would be better for someone truly needing this functionality to add it -- I felt I would not do a good job guessing what might be needed in the future.


Repository:
  rL LLVM

https://reviews.llvm.org/D42082





More information about the llvm-commits mailing list