[PATCH] D41735: Use uint64_t to store the ELF sh_entsize field.

[Rafael Avila de Espindola via llvm-commits]

"Davis, Matthew" <Matthew.Davis at sony.com> writes:

>> From: Rafael Avila de Espindola [mailto:rafael.espindola at gmail.com]
>> Sent: Friday, January 12, 2018 6:46 PM
>> Subject: Re: [PATCH] D41735: Use uint64_t to store the ELF sh_entsize field.
>> 
>> Matt Davis via Phabricator via llvm-commits <llvm-commits at lists.llvm.org>
>> writes:
>> 
>> > mattd added a comment.
>> >
>> > Ping.
>> >
>> > I'm not certain how helpful this change is, per some discussion on the list last
>> week, this change implies that linkers can also support extremely large
>> sh_entsize values.  The intention with this patch is to represent the same
>> sh_entsize size used in elf.h for 64bit elfs.
>> 
>> Sorry, which linker supports this?
>
> I don't know of any, but I haven't really looked.  I figured that if elf.h defined a 64bit sh_entsize then llvm's elf representation should too.

Not necessarily. elf.h has to match the spec, mc only needs to support
what we support in .s files. If no linker supports this, I think it is
better to just produce a clear error message saying it is not supported.

Cheers,
Rafael