[PATCH] D40900: [Sanitizers, test] Fix sanitizer tests on Solaris (PR 33274)

Rainer Orth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 13 09:29:37 PST 2018


ro added inline comments.


================
Comment at: test/asan/TestCases/alloca_vla_interact.cc:17
+#elif defined(__FreeBSD__) || defined(__NetBSD__)
+#include <stdlib.h>
+#else
----------------
krytarowski wrote:
> krytarowski wrote:
> > <stdlib.h> is already included
> I think we should reverse this check.
> 
> Include <alloca.h> for SunOS only.
> 
> <stdlib.h> is enough for all BSDs, Linux, Windows, MacOSX.
> 
Will do. 


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D40900





More information about the llvm-commits mailing list