[PATCH] D42022: Reland "Make TracePcGuardController linker-initialized"

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 12 17:04:01 PST 2018


phosek created this revision.
phosek added a reviewer: mcgrathr.
Herald added subscribers: Sanitizers, llvm-commits, kubamracek.

This broke check-tsan because of linter issues.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D42022

Files:
  lib/sanitizer_common/sanitizer_coverage_fuchsia.cc


Index: lib/sanitizer_common/sanitizer_coverage_fuchsia.cc
===================================================================
--- lib/sanitizer_common/sanitizer_coverage_fuchsia.cc
+++ lib/sanitizer_common/sanitizer_coverage_fuchsia.cc
@@ -49,7 +49,7 @@
 
 // Collects trace-pc guard coverage.
 // This class relies on zero-initialization.
-class TracePcGuardController {
+class TracePcGuardController final {
  public:
   // For each PC location being tracked, there is a u32 reserved in global
   // data called the "guard".  At startup, we assign each guard slot a
@@ -113,11 +113,11 @@
   // We can always spare the 32G of address space.
   static constexpr size_t MappingSize = sizeof(uptr) << 32;
 
-  BlockingMutex setup_lock_;
-  uptr *array_;
-  u32 next_index_;
-  zx_handle_t vmo_;
-  char vmo_name_[ZX_MAX_NAME_LEN];
+  BlockingMutex setup_lock_ {LINKER_INITIALIZED};
+  uptr *array_ {};
+  u32 next_index_ {};
+  zx_handle_t vmo _ {};
+  char vmo_name_[ZX_MAX_NAME_LEN] {};
 
   size_t DataSize() const { return next_index_ * sizeof(uintptr_t); }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42022.129736.patch
Type: text/x-patch
Size: 1062 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180113/38eed2a2/attachment.bin>


More information about the llvm-commits mailing list