[PATCH] D42012: [GlobalISel][TableGen] Add support for SDNodeXForm

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added a comment.

Looks mostly good to me.

Two things:

- The test case doesn't seem to demonstrate what we are adding (see inline comment)
- We miss an entry in the GlobalISel doc to explain this new construction (to be fair we miss the whole TableGen support explanation) (could be a follow-up patch)



================
Comment at: test/CodeGen/AArch64/GlobalISel/select-mul.mir:21
+    ; CHECK: [[MOVi32imm:%[0-9]+]]:gpr32 = MOVi32imm 3
+    ; CHECK: [[SMADDLrrr:%[0-9]+]]:gpr64 = SMADDLrrr [[COPY]], [[MOVi32imm]], %xzr
+    ; CHECK: %x0 = COPY [[SMADDLrrr]]
----------------
I'm confused, isn't the goal of the patch to be able to match the immediate variant here?


https://reviews.llvm.org/D42012