[PATCH] D42010: [LLD][COFF] Report error when file will exceed Windows maximum image size (4GB)

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 12 16:24:22 PST 2018


ruiu added inline comments.


================
Comment at: tools/lld/COFF/Writer.cpp:303-305
+    fatal(formatv(
+        "image size ({0}) exceeds maximum allowable size ({1})",
+        FileSize, UINT32_MAX));
----------------
I believe you can do

 fatal("image size ("+ Twine(FileSize) + ") exceeds maximum allowable size (" + Twine(UINT32_MAX) + ")");


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42010





More information about the llvm-commits mailing list