[PATCH] D42012: [GlobalISel][TableGen] Add support for SDNodeXForm

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added inline comments.


================
Comment at: lib/Target/AArch64/AArch64InstructionSelector.cpp:1531
+  assert(I.getOpcode() == TargetOpcode::G_CONSTANT && "Expected G_CONSTANT");
+  auto CstVal = getConstantVRegVal(I.getOperand(0).getReg(), MRI);
+  assert(CstVal && "Expected constant value");
----------------
Could you put the explicit type here?

In particular, this pattern looks strange:
auto CstVal
*CstVal;

At least, I would expect something along those lines:
auto *CstVal
*CstVal;



https://reviews.llvm.org/D42012