[PATCH] D42013: [WebAssembly] Use ArrayRef over raw pointers

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 12 14:54:39 PST 2018


sbc100 added inline comments.


================
Comment at: wasm/InputChunks.h:150-152
+  ArrayRef<uint8_t> data() const override { return Body; }
+
+  ArrayRef<uint8_t> Body;
----------------
ruiu wrote:
> In lld we don't usually define trivial accessors but instead use data members directly.
Its only trivial for this subclass.. the method is used on the base class and different subclass have different implementations of data().


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42013





More information about the llvm-commits mailing list