[PATCH] D42007: [SimplifyCFG] Try to change store operation type when sinking

[Matthew Simpson via Phabricator via llvm-commits]

mssimpso added a comment.

Thanks for the quick feedback Danny/Davide. I definitely appreciate the point that SimplifyCFG may not be the best place for this kind of transformation. Davide, I assume the dedicated pass you're referring to is GVNSink? I don't think that pass is enabled yet (I haven't been closely following the progress, so I'm not sure what's holding it up at this point), but it's possible GVNSink would indeed catch the cases this patch does. I haven't tested that yet.

For the record, this patch resulted from https://reviews.llvm.org/rL320749. After sinking was moved later in the pipeline, I noticed that SimplifyCFG began missing sinking opportunities that it once caught due to the load/store canonicalization in InstCombine that I mentioned. So the intent wasn't really to extend SimplifyCFG, but to restore it's functionality.


Repository:
  rL LLVM

https://reviews.llvm.org/D42007