[PATCH] D41978: Allow unaligned access to ELF file data structures.

[Rui Ueyama via Phabricator via llvm-commits]

This revision was not accepted when it landed; it landed in state "Needs Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL322407: Allow unaligned access to ELF file data structures. (authored by ruiu, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D41978?vs=129576&id=129704#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D41978

Files:
  llvm/trunk/include/llvm/Object/ELFTypes.h
  llvm/trunk/test/Object/Inputs/invalid-sections-address-alignment.x86-64
  llvm/trunk/test/Object/invalid-alignment.test
  llvm/trunk/test/Object/invalid.test


Index: llvm/trunk/include/llvm/Object/ELFTypes.h
===================================================================
--- llvm/trunk/include/llvm/Object/ELFTypes.h
+++ llvm/trunk/include/llvm/Object/ELFTypes.h
@@ -44,7 +44,7 @@
 template <endianness E, bool Is64> struct ELFType {
 private:
   template <typename Ty>
-  using packed = support::detail::packed_endian_specific_integral<Ty, E, 2>;
+  using packed = support::detail::packed_endian_specific_integral<Ty, E, 1>;
 
 public:
   static const endianness TargetEndianness = E;
Index: llvm/trunk/test/Object/invalid-alignment.test
===================================================================
--- llvm/trunk/test/Object/invalid-alignment.test
+++ llvm/trunk/test/Object/invalid-alignment.test
@@ -1,7 +1,15 @@
 # RUN: yaml2obj %s -o %t.o
-# RUN: not llvm-readobj -r %t.o 2>&1 | FileCheck %s
+# RUN: llvm-readobj -r %t.o 2>&1 | FileCheck %s
 
-# CHECK: Error reading file: unaligned data
+# CHECK:      Format: ELF64-x86-64
+# CHECK-NEXT: Arch: x86_64
+# CHECK-NEXT: AddressSize: 64bit
+# CHECK-NEXT: LoadName:
+# CHECK-NEXT: Relocations [
+# CHECK-NEXT:   Section (2) .rela.foo {
+# CHECK-NEXT:     0x0 R_X86_64_NONE - 0x0
+# CHECK-NEXT:   }
+# CHECK-NEXT: ]
 
 --- !ELF
 FileHeader:
Index: llvm/trunk/test/Object/invalid.test
===================================================================
--- llvm/trunk/test/Object/invalid.test
+++ llvm/trunk/test/Object/invalid.test
@@ -70,10 +70,6 @@
 RUN:   FileCheck --check-prefix=INVALID-RELOC-SH-OFFSET %s
 INVALID-RELOC-SH-OFFSET: invalid section offset
 
-RUN: not llvm-readobj -t %p/Inputs/invalid-sections-address-alignment.x86-64 2>&1 | \
-RUN:   FileCheck --check-prefix=INVALID-SEC-ADDRESS-ALIGNMENT %s
-INVALID-SEC-ADDRESS-ALIGNMENT: invalid alignment of section headers
-
 RUN: not llvm-readobj -t %p/Inputs/invalid-section-size2.elf 2>&1 | \
 RUN:   FileCheck --check-prefix=INVALID-SECTION-SIZE2 %s
 INVALID-SECTION-SIZE2: invalid section offset


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41978.129704.patch
Type: text/x-patch
Size: 1965 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180112/684b24d2/attachment.bin>