[PATCH] D41297: [ThinLTO] Implement summary visualizer

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added inline comments.


================
Comment at: lib/IR/ModuleSummaryIndex.cpp:275
+
+  for (auto &E : CrossModuleEdges) {
+    auto &ModList = NodeMap[E.Dst];
----------------
Why are the nodes and edges emitted this way - i.e. intra-module first, then cross-module? Why not just want the index and emit all the edges in one sweep? That would certainly be less expensive. You could just use the module Id stored in the module path string table (see ModuleSummaryIndex::getModuleId) instead of generating your own, or use the module hash

It might be nice to emit the full module path somewhere (maybe as a comment).


https://reviews.llvm.org/D41297