[PATCH] D41954: [WebAssembly] Refactor symbol index handling (LLVM)

[Nicholas Wilson via Phabricator via llvm-commits]

ncw updated this revision to Diff 129651.
ncw marked 6 inline comments as done.
ncw edited the summary of this revision.
ncw added reviewers: sbc100, sunfish.
ncw added a comment.

Changes:

- Responded to Sam's feedback
- Fixed all test failures

It's pretty large, I'll look into splitting up into a couple of smaller commits. That drags out the time to get the chain of patches committed which increases rebasing time... but it's probably worth doing here. I'll have to come back to it next week, I can't do any more refactoring on it this week.

I'm happy with my changes overall now.


Repository:
  rL LLVM

https://reviews.llvm.org/D41954

Files:
  include/llvm/BinaryFormat/Wasm.h
  include/llvm/Object/Wasm.h
  include/llvm/ObjectYAML/WasmYAML.h
  lib/MC/WasmObjectWriter.cpp
  lib/Object/WasmObjectFile.cpp
  lib/ObjectYAML/WasmYAML.cpp
  test/MC/WebAssembly/array-fill.ll
  test/MC/WebAssembly/comdat.ll
  test/MC/WebAssembly/external-func-address.ll
  test/MC/WebAssembly/func-address.ll
  test/MC/WebAssembly/global-ctor-dtor.ll
  test/MC/WebAssembly/unnamed-data.ll
  test/MC/WebAssembly/visibility.ll
  test/MC/WebAssembly/weak-alias.ll
  test/MC/WebAssembly/weak.ll
  test/ObjectYAML/wasm/linking_section.yaml
  test/ObjectYAML/wasm/weak_symbols.yaml
  test/tools/llvm-nm/wasm/exports.yaml
  test/tools/llvm-nm/wasm/weak-symbols.yaml
  test/tools/llvm-objdump/WebAssembly/symbol-table.test
  test/tools/llvm-readobj/symbols.test
  tools/llvm-readobj/WasmDumper.cpp
  tools/obj2yaml/wasm2yaml.cpp
  tools/yaml2obj/yaml2wasm.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41954.129651.patch
Type: text/x-patch
Size: 71628 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180112/48a28d79/attachment.bin>