[PATCH] D39888: [Sanitizers, LSan, Darwin] Allow for lack of VM_MEMORY_OS_ALLOC_ONCE

Rainer Orth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 12 08:53:12 PST 2018


ro added a comment.

In https://reviews.llvm.org/D39888#971254, @fjricci wrote:

> I think it would be preferable to define this as a separate constant (perhaps `kSanitizerVmMemoryOsAllocOnce`, like @kubamracek suggested), which is set to `VM_MEMORY_OS_ALLOC_ONCE` if defined, and some other value (that 73 perhaps?) otherwise. Makes it clear that the constant used by the code isn't necessarily the same as the one set by the system.


73 *is* the Mac OS X 10.9 value of VM_MEMORY_OS_ALLOC_ONCE.  On older systems, it will never be returned by the kernel, we just need a way to
have the code compile.  I don't care which way it's done actually.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D39888





More information about the llvm-commits mailing list