[llvm] r322375 - [docs] Tweak update to Phabricator docs about setting repository for diffs uploaded via web

Ben Hamilton via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 12 07:44:35 PST 2018


Author: benhamilton
Date: Fri Jan 12 07:44:35 2018
New Revision: 322375

URL: http://llvm.org/viewvc/llvm-project?rev=322375&view=rev
Log:
[docs] Tweak update to Phabricator docs about setting repository for diffs uploaded via web

Summary:
In D41919, I missed that there was a *second* step when uploading
diffs via web where the repository should be specified.

Reviewers: asb, probinson

Reviewed By: asb

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D41956

Modified:
    llvm/trunk/docs/Phabricator.rst

Modified: llvm/trunk/docs/Phabricator.rst
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/docs/Phabricator.rst?rev=322375&r1=322374&r2=322375&view=diff
==============================================================================
--- llvm/trunk/docs/Phabricator.rst (original)
+++ llvm/trunk/docs/Phabricator.rst Fri Jan 12 07:44:35 2018
@@ -65,15 +65,16 @@ To upload a new patch:
 * Click *Differential*.
 * Click *+ Create Diff*.
 * Paste the text diff or browse to the patch file. Click *Create Diff*.
-* In the Repository field, enter the name of the project (LLVM, Clang,
-  etc.) to which the review should be sent.
+* Leave this first Repository field blank. (We'll fill in the Repository
+  later, when sending the review.)
 * Leave the drop down on *Create a new Revision...* and click *Continue*.
 * Enter a descriptive title and summary.  The title and summary are usually
   in the form of a :ref:`commit message <commit messages>`.
 * Add reviewers (see below for advice). (If you set the Repository field
   correctly, llvm-commits or cfe-commits will be subscribed automatically;
   otherwise, you will have to manually subscribe them.)
-* Leave the Repository and Project fields blank.
+* In the Repository field, enter the name of the project (LLVM, Clang,
+  etc.) to which the review should be sent.
 * Click *Save*.
 
 To submit an updated patch:
@@ -83,7 +84,8 @@ To submit an updated patch:
 * Paste the updated diff or browse to the updated patch file. Click *Create Diff*.
 * Select the review you want to from the *Attach To* dropdown and click
   *Continue*.
-* Leave the Repository and Project fields blank.
+* Leave the Repository field blank. (We previously filled out the Repository
+  for the review request.)
 * Add comments about the changes in the new diff. Click *Save*.
 
 Choosing reviewers: You typically pick one or two people as initial reviewers.




More information about the llvm-commits mailing list