[PATCH] D41187: Ignore metainstructions during the shrink wrap analysis

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 12 07:12:31 PST 2018


MatzeB added inline comments.


================
Comment at: llvm/trunk/lib/CodeGen/ShrinkWrap.cpp:244
+  // Ignore DBG_VALUE and other meta instructions that must not affect codegen.
+  if (MI.isMetaInstruction())
+    return false;
----------------
thegameg wrote:
> Do we also want to ignore
> ```
> %csr = IMPLICIT_DEF
> ```
> ?
> 
> I remember @MatzeB suggested this approach to me to write cleaner tests.
Should probably do `MO.isDef() || MO.readsReg()` below instead of this check.


Repository:
  rL LLVM

https://reviews.llvm.org/D41187





More information about the llvm-commits mailing list