[PATCH] D41975: [WebAssembly] Don't allow functions to be named more than once
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 11 18:43:25 PST 2018
ruiu added inline comments.
================
Comment at: wasm/Writer.cpp:447
+ continue;
+ if (!Seen.insert(S->getOutputIndex()).second)
continue;
----------------
In lld we carefully avoid using hash table because hash table is slow. In general, we lookup the hash table (the SymbolTable) only once for a name, and don't insert symbol names into any other hash tables. Can you avoid doing that here?
Repository:
rLLD LLVM Linker
https://reviews.llvm.org/D41975
More information about the llvm-commits
mailing list