[PATCH] D41926: [DWARFv5] CodeGen support for MD5 checksum

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

Thanks!  I'll commit this tomorrow.



================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp:103
   // extend .file to support this.
+  unsigned CUID = Asm->OutStreamer->hasRawTextSupport() ? 0 : getUniqueID();
+  if (!File)
----------------
aprantl wrote:
> Should this be an Optional<unsigned> parameter instead of using 0?
Assembler text doesn't have a way to describe line tables for multiple compilation units (like you could get with LTO), so the line tables all get mooshed into CU 0.  And this parameter gets used as an array index, so it really does want to be 0 in that case.


https://reviews.llvm.org/D41926