[PATCH] D41664: Remove test which assumed array cookies can't be poisoned when using an operator new defined in a class

Kostya Serebryany via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 11 12:59:16 PST 2018


kcc added a comment.

Let me rephrase the question. 
Is the code in new_array_cookie_with_new_from_class.cc a valid C++? 
I.e. is the code allowed to access *reinterpret_cast<uintptr_t*>(Foo::allocated) at line 38?

If this code is valid, your change https://reviews.llvm.org/D41301 will make asan bark on a valid code, which is exactly what this test is protecting from.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D41664





More information about the llvm-commits mailing list