[PATCH] D41602: [hwasan] Stack instrumentation.

Kostya Serebryany via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 11 12:29:22 PST 2018


kcc added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:355
+    //   IRB.CreateStore(JustTag, IRB.CreateConstGEP1_32(ShadowPtr, i));
+    IRB.CreateMemSet(ShadowPtr, JustTag, ShadowSize, /*Align=*/1);
+  }
----------------
kcc wrote:
> Will this work if 
>   * the size is large and memset doesn't get inlined
>   * hwasan has the msan interceptor
> ? 
I mean, 
* hwasan has the memset interceptor


https://reviews.llvm.org/D41602





More information about the llvm-commits mailing list