[llvm] r322290 - [docs] Update Phabricator docs about setting repository for diffs uploaded via web

[Robinson, Paul via llvm-commits]

> -----Original Message-----
> From: llvm-commits [mailto:llvm-commits-bounces at lists.llvm.org] On Behalf
> Of Ben Hamilton via llvm-commits
> Sent: Thursday, January 11, 2018 8:30 AM
> To: llvm-commits at lists.llvm.org
> Subject: [llvm] r322290 - [docs] Update Phabricator docs about setting
> repository for diffs uploaded via web
> 
> Author: benhamilton
> Date: Thu Jan 11 08:30:08 2018
> New Revision: 322290
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=322290&view=rev
> Log:
> [docs] Update Phabricator docs about setting repository for diffs uploaded
> via web
> 
> Summary:
> Docs are out of date now that we have separate repositories for LLVM,
> Clang, etc.
> 
> Reviewers: asb
> 
> Reviewed By: asb
> 
> Differential Revision: https://reviews.llvm.org/D41919
> 
> Modified:
>     llvm/trunk/docs/Phabricator.rst
> 
> Modified: llvm/trunk/docs/Phabricator.rst
> URL: http://llvm.org/viewvc/llvm-
> project/llvm/trunk/docs/Phabricator.rst?rev=322290&r1=322289&r2=322290&vie
> w=diff
> ==========================================================================
> ====
> --- llvm/trunk/docs/Phabricator.rst (original)
> +++ llvm/trunk/docs/Phabricator.rst Thu Jan 11 08:30:08 2018
> @@ -65,14 +65,14 @@ To upload a new patch:
>  * Click *Differential*.
>  * Click *+ Create Diff*.
>  * Paste the text diff or browse to the patch file. Click *Create Diff*.
> -* Leave the Repository field blank.
> +* In the Repository field, enter the name of the project (LLVM, Clang,
> +  etc.) to which the review should be sent.
>  * Leave the drop down on *Create a new Revision...* and click *Continue*.
>  * Enter a descriptive title and summary.  The title and summary are
> usually
>    in the form of a :ref:`commit message <commit messages>`.
> -* Add reviewers (see below for advice) and subscribe mailing
> -  lists that you want to be included in the review. If your patch is
> -  for LLVM, add llvm-commits as a Subscriber; if your patch is for Clang,
> -  add cfe-commits.
> +* Add reviewers (see below for advice). (If you set the Repository field
> +  correctly, llvm-commits or cfe-commits will be subscribed
> automatically;
> +  otherwise, you will have to manually subscribe them.)
>  * Leave the Repository and Project fields blank.

Set the Repository field?  Then leave it blank?
If there are two web forms with a Repository field and it matters which
one is filled in, I think that ought to be clarified.  If this last
bullet just shouldn't mention the Repository, please fix that.
Thanks,
--paulr

>  * Click *Save*.
> 
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits