[PATCH] D41390: [WebAssembly] LLD: Don't write out discarded function symbols

[Nicholas Wilson via Phabricator via llvm-commits]

ncw abandoned this revision.
ncw added a comment.

I'm abandoning this!

The changes are too small and not worth doing really, if we plan to merge Comdat support without having general weak-symbol discarding.

Presumably this case will be eventually covered by a GC implementation.



================
Comment at: wasm/InputChunks.cpp:26
+  }
+}
 
----------------
sbc100 wrote:
> This size of a global symbol isn't represented this way.  In fact we don't represent the size at all currently.   
It took me a moment to see what you mean - the type doesn't tell you the size! For a struct, it seems like the type is 'i32', although the size will be typically much larger than 4.

OK, this doesn't work. We can't exclude Segments based on whether all the data in them is part of a global - maybe we can assume though that each global "owns" the segment that contains it?

Doesn't really matter, I'll abandon this revision.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D41390