[PATCH] D41920: [DWARF][NFC] Prep for upcoming DWARF v5 string offsets table producer patch.

Wolfgang Pieb via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 10 17:43:02 PST 2018


wolfgangp marked an inline comment as done.
wolfgangp added a comment.

In https://reviews.llvm.org/D41920#972755, @aprantl wrote:

> Could you please upload patches with more context in the future? git diff -U9999 is good :-)


Yeah, sorry, I usually do that. Somehow I forgot to do it this time.
Thanks for the quick review.



================
Comment at: include/llvm/CodeGen/DwarfStringPoolEntry.h:44
   StringRef getString() const { return I->first(); }
+  DwarfStringPoolEntry getEntry() const { return I->getValue(); }
 
----------------
aprantl wrote:
> Comment perhaps?
Mostly a convenience, so the caller doesn't have to puzzle the string pool entry together from its components. I add a comment before I commit.


https://reviews.llvm.org/D41920





More information about the llvm-commits mailing list