[PATCH] D41857: [Mips] Handle one byte illegal relocations

[Simon Dardis via Phabricator via llvm-commits]

sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.

Two additional nits to the ones inlined, rather that use the term 'illegal' say 'unsupported', this goes for the title as well as the test file name.

Also, the summary should be "Fail gracefully" rather than "Exit gracefully".

Otherwise LGTM.



================
Comment at: lib/Target/Mips/MCTargetDesc/MipsELFObjectWriter.cpp:229
+  case FK_Data_1:
+    report_fatal_error("Mips does not support one byte fixups");
   case Mips::fixup_Mips_16:
----------------
Nit: Mips does not support one byte fixups -> MIPS does not support one byte relocations


================
Comment at: test/MC/Mips/illegal-relocation.s:3
+# RUN: FileCheck %s < %t
+
+        .globl x
----------------
Nit: description.


https://reviews.llvm.org/D41857