[PATCH] D41915: [lldCOFF] Print detailed timing information with /VERBOSE

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 10 13:31:59 PST 2018


ruiu added inline comments.


================
Comment at: lld/COFF/PDB.cpp:1014-1015
+
+  PdbCommitTimer.end();
+  FullPdbLinkTimer.end();
 }
----------------
zturner wrote:
> ruiu wrote:
> > These things should be done in the RAII style.
> I didn't do RAII style here because we want to start and stop in the middle of functions sometimes.  It seemed inconvenient to have to make a nested scope just for that.
I guess it's because the timing information is printed out along with other debug info. How about adding a new command line just for this feature?


https://reviews.llvm.org/D41915





More information about the llvm-commits mailing list