[PATCH] D31528: [ELF][MIPS] Multi-GOT implementation

Simon Atanasyan via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 10 13:09:20 PST 2018


On Thu, Jan 11, 2018 at 12:02 AM, Alexander Richardson via Phabricator
<reviews at reviews.llvm.org> wrote:
> arichardson added a comment.
>
> I would be really great if this patch could be added to LLD soon. I believe this is the last change needed before we can use LLD to build the whole FreeBSD MIPS base system.
>
> Could you rebase this on the latest master please? I tried updating our LLD fork  (which includes this patch) to Jan 1st and am now getting three test failures:
>
>   Failing Tests (3):
>       lld :: ELF/mips-got-redundant.s
>       lld :: ELF/mips-got16.s
>       lld :: ELF/mips-mgot.s
>
> I have not debugged yet whether if this is because I didn't resolve the merge conflicts correctly or whether LLD has changed in a way that breaks the tests.

Unfortunately some latest changes broke the patch. I supported the
patch during short nine-months period of reviewing. For the latest
breakage I could not find a fix quickly. I'm going to provide the fix
but obviously it's not a candidate for the nearest LLD release. Sorry.

-- 
Simon Atanasyan


More information about the llvm-commits mailing list