[PATCH] D40805: [RISCV] Support for varargs

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 10 11:36:02 PST 2018


asb added inline comments.


================
Comment at: lib/Target/RISCV/RISCVISelLowering.cpp:719
+      SDValue Store =
+          DAG.getStore(Chain, DL, ArgValue, PtrOff, MachinePointerInfo());
+      cast<StoreSDNode>(Store.getNode())
----------------
kparzysz wrote:
> kparzysz wrote:
> > You could use MachinePointerInfo::getFixedStack instead of an empty pointer info to get more accurate aliasing.
> Other than that, LGTM.
Good spot, making that change and applying now. Thanks for the reviews everyone.


https://reviews.llvm.org/D40805





More information about the llvm-commits mailing list