[PATCH] D41865: X86: Fix LowerBUILD_VECTORAsVariablePermute for case Src is smaller than Indices

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 10 08:24:23 PST 2018


RKSimon added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:7867
+  if (SrcVec.getValueSizeInBits() < IndicesVT.getSizeInBits()) {
+    SrcVec = DAG.getNode(ISD::INSERT_SUBVECTOR, SDLoc(SrcVec), IndicesVT,
+                         DAG.getUNDEF(IndicesVT), SrcVec,
----------------
I don't think you should use IndicesVT - (what happens with <8 x float> @pr35820_alt(<4 x float> %v, <8 x i32> %indices) ?


https://reviews.llvm.org/D41865





More information about the llvm-commits mailing list