[PATCH] D41728: [TableGen][AsmMatcherEmitter] Remove boolean 'Hack' parameter

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 10 06:54:46 PST 2018


fhahn added inline comments.


================
Comment at: utils/TableGen/AsmMatcherEmitter.cpp:1119
     if (Tok[0] == '$' && !OperandNames.insert(Tok).second) {
-      if (!Hack)
-        PrintFatalError(TheDef->getLoc(),
-                        "ERROR: matchable with tied operand '" + Tok +
-                        "' can never be matched!");
-      // FIXME: Should reject these.  The ARM backend hits this with $lane in a
-      // bunch of instructions.  It is unclear what the right answer is.
       DEBUG({
         errs() << "warning: '" << TheDef->getName() << "': "
----------------
This warning will only be shown if tablegen is run with `-debug`, which is not the case for normal debug builds (AFAIK)


https://reviews.llvm.org/D41728





More information about the llvm-commits mailing list