[PATCH] D41439: [mips] Properly select abs and sqrt instructions

Stefan Maksimovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 10 05:45:26 PST 2018


smaksimovic updated this revision to Diff 129261.
smaksimovic added a comment.

Addressed review comments.

I made a rather inconvenient naming change to the MMR6 version of SQRT.
The `SQRT_D_MMR6`, as it was originally named, came after `FSQRT_D64_MM` in the match table residing in `MipsGenAsmMatcher.inc`.
This was not the case with ABS, so it seems that the instructions are ordered by name as well, among other things.
Renamed `SQRT_D_MMR6` to `ASQRT_D_MMR6`. I didn't find another way to force the ordering of records in the match table.


https://reviews.llvm.org/D41439

Files:
  lib/Target/Mips/MicroMips32r6InstrInfo.td
  lib/Target/Mips/MicroMipsInstrFPU.td
  lib/Target/Mips/MipsInstrFPU.td
  test/CodeGen/Mips/llvm-ir/abs.ll
  test/CodeGen/Mips/llvm-ir/sqrt.ll
  test/MC/Disassembler/Mips/micromips32r3/valid-el.txt
  test/MC/Disassembler/Mips/micromips32r3/valid-fp64-el.txt
  test/MC/Disassembler/Mips/micromips32r3/valid-fp64.txt
  test/MC/Disassembler/Mips/micromips32r3/valid.txt
  test/MC/Disassembler/Mips/mips32/valid-fp64-el.txt
  test/MC/Disassembler/Mips/mips32/valid-fp64.txt
  test/MC/Disassembler/Mips/mips32r2/valid-fp64-el.txt
  test/MC/Disassembler/Mips/mips32r2/valid-fp64.txt
  test/MC/Disassembler/Mips/mips32r3/valid-fp64-el.txt
  test/MC/Disassembler/Mips/mips32r3/valid-fp64.txt
  test/MC/Disassembler/Mips/mips32r5/valid-fp64-el.txt
  test/MC/Disassembler/Mips/mips32r5/valid-fp64.txt
  test/MC/Mips/micromips/valid-fp64.s
  test/MC/Mips/micromips/valid.s
  test/MC/Mips/micromips32r6/valid.s
  test/MC/Mips/mips1/valid.s
  test/MC/Mips/mips2/valid.s
  test/MC/Mips/mips32/valid.s
  test/MC/Mips/mips32r2/valid-fp64.s
  test/MC/Mips/mips32r2/valid.s
  test/MC/Mips/mips32r3/valid-fp64.s
  test/MC/Mips/mips32r3/valid.s
  test/MC/Mips/mips32r5/valid-fp64.s
  test/MC/Mips/mips32r5/valid.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41439.129261.patch
Type: text/x-patch
Size: 37466 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180110/accba348/attachment.bin>


More information about the llvm-commits mailing list