[PATCH] D41762: [DWARF] Incorrect prologue end line record.

[Carlos Alberto Enciso via Phabricator via llvm-commits]

CarlosAlbertoEnciso added a comment.

In https://reviews.llvm.org/D41762#968441, @aprantl wrote:

> Just a general comment: It is easier to review patches with more context. I usually upload the output of `git diff HEAD~1 -U9999`.


Thanks very much for your suggestion. Would you like for me to update te patch?



================
Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:1172
+  // If the instruction is part of the function frame setup code, do not emit
+  // any line record, as there is no correspondence with any user code.
+  if (MI->isMetaInstruction() || MI->getFlag(MachineInstr::FrameSetup))
----------------
aprantl wrote:
> Can you explain why this is necessary / convince me that this is also true for shrink-wrapped code? I could imagine that for shrink-wrapped code, where the frame setup is sunk to the latest possible point it would still be useful to know accurate line numbers for code before the frame setup.
I will have a look at it. Thanks.


Repository:
  rL LLVM

https://reviews.llvm.org/D41762