[PATCH] D41640: [ELF] - Do not ignore discarding of .rela.plt/.rela.dyn

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 9 17:28:00 PST 2018


ruiu added inline comments.


================
Comment at: ELF/LinkerScript.cpp:293-295
+      // We do not ignore linker-synthesized sections here because
+      // want to error out when discarding them with scripts like
+      //   /DISCARD/ : { *(.rela.dyn) }
----------------
ruiu wrote:
> I think I don't understand this comment. How is /DISCARD/ related to the synthetic section?
Then please update the comment. This comment can be understood only when you know ".rela.dyn" is a linker-synthesized section, but describing that is not the point of this particular comment.


https://reviews.llvm.org/D41640





More information about the llvm-commits mailing list