[PATCH] D41613: [ELF] - Do not use HeaderSize for conditions in PltSection.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 9 16:52:20 PST 2018


Rui Ueyama via Phabricator <reviews at reviews.llvm.org> writes:

> ruiu added a comment.
>
> Isn't it an ABI violation not to write the PLT header for PPC64? If so, we fix that ABI violation rather than "correctly" emitting ABI-violating executables.

The PPC64 implementation is incomplete. Finishing it would be nice, but
independent of this change.

Without this change a target must set Target->PltHeaderSize to avoid
having lld confuse the plt and iplt sections, which is not a good design
IMHO.

Cheers,
Rafael


More information about the llvm-commits mailing list