[PATCH] D41226: [LiveDebugValues] recognize spilled register that is killed in instruction after the spill

Bjorn Pettersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 9 13:32:10 PST 2018


bjope added a comment.

In https://reviews.llvm.org/D41226#969976, @wolfgangp wrote:

> I agree that this is a solution to a specific case. I would be OK with it going in for now (after addressing the remaining review comments) with a FIXME comment added to provide a more comprehensive solution later, i.e. one that addresses bundles and kills in instructions further down the chain, as Bjorn suggested.


Ok, that is fine with me. The FIXME tells me that the current solution is a deliberate choice (without the FIXME the code looks incomplete, and it is hard to tell what kind of scenarios the author was aiming for). Thanks!


https://reviews.llvm.org/D41226





More information about the llvm-commits mailing list