[PATCH] D41851: X86 Tests: Update more isel tests with FastVariableShuffle feature

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 9 03:45:54 PST 2018


RKSimon added a comment.

A few minor observations. Assuming https://reviews.llvm.org/D41436 is accepted, is the plan to remove the +fast-variable-shuffle arg from the avx512 cases? In which case might it make sense to commit the avx2 and avx512 changes separately?



================
Comment at: test/CodeGen/X86/avx2-conversions.ll:5
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx2 | FileCheck %s --check-prefixes=X64,X64-SLOW
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx2,+fast-variable-shuffle | FileCheck %s --check-prefixes=X64-FAST
 
----------------
--check-prefixes=X64,X64-FAST


================
Comment at: test/CodeGen/X86/psubus.ll:6
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx | FileCheck %s --check-prefixes=AVX,AVX1
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx2 | FileCheck %s -check-prefixes=AVX,AVX2,AVX2-SLOW
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx2,+fast-variable-shuffle | FileCheck %s --check-prefixes=AVX,AVX2,AVX2-FAST
----------------
--check-prefixes=AVX,AVX2,AVX2-SLOW


================
Comment at: test/CodeGen/X86/psubus.ll:8
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx2,+fast-variable-shuffle | FileCheck %s --check-prefixes=AVX,AVX2,AVX2-FAST
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx512bw,+avx512vl,+fast-variable-shuffle | FileCheck %s --check-prefixes=AVX,AVX512
 
----------------
Possibly do the prefix cleanup as separate commit straight away?


https://reviews.llvm.org/D41851





More information about the llvm-commits mailing list