[PATCH] D41855: [ARM] Fix erroneous availability of SMMLS for Armv7-M

Andre Vieira via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 9 03:40:32 PST 2018


avieira added inline comments.


================
Comment at: test/CodeGen/ARM/smml.ll:2
 ; RUN: llc -mtriple=arm-eabi %s -o - | FileCheck %s -check-prefix=CHECK -check-prefix=CHECK-V4
-; RUN: llc -mtriple=armv6-eabi %s -o - | FileCheck %s -check-prefix=CHECK -check-prefix=CHECK-V6
+; RUN: llc -mtriple=armv6t2-eabi %s -o - | FileCheck %s -check-prefix=CHECK -check-prefix=CHECK-V6
 ; RUN: llc -mtriple=armv7-eabi %s -o - | FileCheck %s -check-prefix=CHECK -check-prefix=CHECK-V6
----------------
samparker wrote:
> This duplicates line 6, and why remove the v6 triple? And what about a test that ensures v7E-M works?
It does indeed, didnt see it. As for v7E-M... that was in the other patch, Ill add one here too. Thanks.


https://reviews.llvm.org/D41855





More information about the llvm-commits mailing list