[PATCH] D41632: [LLD] [COFF] Keep the underscore on exported decorated stdcall functions

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 8 23:15:40 PST 2018


mstorsjo added a comment.

In https://reviews.llvm.org/D41632#970546, @ruiu wrote:

> Hmm, if we have to do this, this patch is okay, but it feels to me we are building a complex theory to describe the behavior of the MSVC linker, but the MSVC linker is likely to follow some simple rules that we do not understand yet.


Yes, I have the exact same feeling.

> Do you think we can find simpler rules to describe all these behaivors?

Maybe, but I think it probably would require adjusting a lot of the logic about how symbol names are decorated/undecorated throughout the linker. A couple months ago when I revisited this topic the last time, I was able to make all the other cases work pretty easily, except this one, and I had hoped nobody actually used/cared about the behaviour in this one.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D41632





More information about the llvm-commits mailing list