[PATCH] D41847: [ELF] Explicit template instantiations for addFile

[Rafael Avila de Espindola via llvm-commits]

LGTM.

Thanks.


Easwaran Raman via Phabricator <reviews at reviews.llvm.org> writes:

> eraman created this revision.
> eraman added a reviewer: espindola.
> Herald added a subscriber: emaste.
>
> All other templated methods have explicit instantiations but this one is
> missing. Discovered while building with a clang with inliner
> modifications.
>
>
> Repository:
>   rLLD LLVM Linker
>
> https://reviews.llvm.org/D41847
>
> Files:
>   ELF/SymbolTable.cpp
>
>
> Index: ELF/SymbolTable.cpp
> ===================================================================
> --- ELF/SymbolTable.cpp
> +++ ELF/SymbolTable.cpp
> @@ -763,6 +763,11 @@
>      Sym->parseSymbolVersion();
>  }
>  
> +template void SymbolTable::addFile<ELF32LE>(InputFile *);
> +template void SymbolTable::addFile<ELF32BE>(InputFile *);
> +template void SymbolTable::addFile<ELF64LE>(InputFile *);
> +template void SymbolTable::addFile<ELF64BE>(InputFile *);
> +
>  template void SymbolTable::addSymbolWrap<ELF32LE>(StringRef);
>  template void SymbolTable::addSymbolWrap<ELF32BE>(StringRef);
>  template void SymbolTable::addSymbolWrap<ELF64LE>(StringRef);
>
>
> Index: ELF/SymbolTable.cpp
> ===================================================================
> --- ELF/SymbolTable.cpp
> +++ ELF/SymbolTable.cpp
> @@ -763,6 +763,11 @@
>      Sym->parseSymbolVersion();
>  }
>  
> +template void SymbolTable::addFile<ELF32LE>(InputFile *);
> +template void SymbolTable::addFile<ELF32BE>(InputFile *);
> +template void SymbolTable::addFile<ELF64LE>(InputFile *);
> +template void SymbolTable::addFile<ELF64BE>(InputFile *);
> +
>  template void SymbolTable::addSymbolWrap<ELF32LE>(StringRef);
>  template void SymbolTable::addSymbolWrap<ELF32BE>(StringRef);
>  template void SymbolTable::addSymbolWrap<ELF64LE>(StringRef);