[PATCH] D41689: [SCEVAA] Don't crash on pointers with no dominance relationship.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 8 14:18:10 PST 2018


efriedma added a comment.

> If we wanted to handle this somehow in SCEVAAResult::alias, can't we just put a dominance check on the values directly instead of trying to examine the SCEVs?

Oh.  Yes, that would be simpler. :)  Maybe slightly less powerful, depending on the structure of the code.

> I think that what AliasSetPrinter is doing is just not well defined

In this case, it's probably worth noting that I have a testcase which doesn't involve aa-eval; BasicAA also makes queries like this (see BasicAAResult::aliasPHI).  I can reduce it if that would be interesting.


Repository:
  rL LLVM

https://reviews.llvm.org/D41689





More information about the llvm-commits mailing list